V4 create pool #788
Merged
V4 create pool #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
akarys92
reviewed
Oct 4, 2024
| @@ -2,6 +2,165 @@ | |||
| title: Create Pool | |||
| --- | |||
|
|
|||
| ## 🚧 Under construction 🚧 | |||
| ### Context | |||
There was a problem hiding this comment.
Why start with an H3? This renders weird to my eye on the actual page. Maybe should be an H2 since it's the first header?
| Please see https://www.v4-by-example.org/initialize | ||
| Creating a pool on Uniswap v4 is permissionless and enables the trading of an asset. | ||
|
|
||
| Below, there are two approaches to creating a pool: |
There was a problem hiding this comment.
We should flesh this intro out a bit more. Why would a developer want to create a pool? At the end of this guide what will be true that isn't when they started? Any pre-reqs they should be aware of? Feels abrupt to just jump in like this.
| forge install uniswap/v4-periphery | ||
| ``` | ||
|
|
||
| ## Guide: Create a Pool Only |
There was a problem hiding this comment.
Would be good to clarify in what case would someone create a pool with no liquidity?
| ``` | ||
| > Excess Ether is **NOT** refunded unless developers encoded `SWEEP` in the `actions` parameter | ||
|
|
||
| For a full end-to-end script, developers should see [v4-template#script](https://github.com/uniswapfoundation/v4-template/tree/main/script) |
akarys92
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.